Add support for DuckDB 1.1.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To build the gem on my macOS machine I had to specify the duckdb dir. Not sure why it is not found automatically? Also, the GitHub Actions workflow no longer works. |
|
Thanks. |
|
Could you rebase on master? |
stenlarsson
force-pushed
the
duckdb-1.1.0
branch
from
609368d
to
791f6e5
Compare
|
Seems to work now, thanks! https://github.com/stenlarsson/red-arrow-duckdb/actions/runs/11249869803 |
kou
reviewed
Oct 10, 2024
ext/arrow-duckdb/arrow-duckdb.cpp
Outdated
| @@ -99,7 +101,7 @@ namespace { | |||
| result_ensure_gschema(Result *result) | |||
| { | |||
| ArrowSchema c_abi_schema; | |||
| duckdb_arrow_schema schema = &c_abi_schema; | |||
| duckdb_arrow_schema schema = reinterpret_cast<duckdb_arrow_schema>(&c_abi_schema); | |||
There was a problem hiding this comment.
Suggested change
| duckdb_arrow_schema schema = reinterpret_cast<duckdb_arrow_schema>(&c_abi_schema); | |
| auto schema = reinterpret_cast<duckdb_arrow_schema>(&c_abi_schema); |
ext/arrow-duckdb/arrow-duckdb.cpp
Outdated
| @@ -121,7 +123,7 @@ namespace { | |||
| result_fetch_internal(VALUE self, Result *result) | |||
| { | |||
| ArrowArray c_abi_array = {}; | |||
| duckdb_arrow_array array = &c_abi_array; | |||
| duckdb_arrow_array array = reinterpret_cast<duckdb_arrow_array>(&c_abi_array); | |||
There was a problem hiding this comment.
Suggested change
| duckdb_arrow_array array = reinterpret_cast<duckdb_arrow_array>(&c_abi_array); | |
| auto array = reinterpret_cast<duckdb_arrow_array>(&c_abi_array); |
ext/arrow-duckdb/arrow-duckdb.cpp
Outdated
| @@ -220,7 +222,7 @@ namespace { | |||
| query_sql_arrow(VALUE self, VALUE sql) | |||
| { | |||
| rubyDuckDBConnection *ctx; | |||
| Data_Get_Struct(self, rubyDuckDBConnection, ctx); | |||
| ctx = get_struct_connection(self); | |||
There was a problem hiding this comment.
Could you remove rubyDuckDBConnection *ctx; and use auto ctx = ... instead?
This fixes a number of errors due to changes in DuckDB and ruby-duckdb between 0.5.0 and 1.1.0.
stenlarsson
force-pushed
the
duckdb-1.1.0
branch
from
791f6e5
to
1e8b5f1
Compare
|
Updated according to review comments. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of errors due to changes in DuckDB and ruby-duckdb between 0.5.0 and 1.1.0.