Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of Python 3.12 #2098

Open
wants to merge 35 commits into
base: staging
Choose a base branch
from
Open

Support of Python 3.12 #2098

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
b3abc8a
Enabling python 3.12 #2097
miguelgfierro May 15, 2024
809a1d3
Enabling python 3.12 #2097
miguelgfierro May 15, 2024
496b22f
Cornac>2
miguelgfierro May 15, 2024
2b9ddcc
setuptools >= 67
daviddavo May 15, 2024
69f2d36
Temporary use lightfm patch
daviddavo May 21, 2024
d497fc0
Merge branch 'staging' into python312
daviddavo Jul 1, 2024
c223e3d
Updated tensorflow
daviddavo Jul 3, 2024
75b884b
Update pymanopt
daviddavo Jul 3, 2024
0c28cf1
Installing pymanopt from git
daviddavo Jul 3, 2024
ad0c79d
Add setuptools (for python 3.12)
daviddavo Jul 3, 2024
cdf9515
Use numpy 1.26 on python 3.12
daviddavo Jul 3, 2024
a442edb
Update python version used to launch tests
daviddavo Jul 3, 2024
dff4b0c
Added numpy 1.26 setup requires on python 3.12
daviddavo Jul 5, 2024
2af59a1
[test ci] Force numpy 1.26
daviddavo Jul 5, 2024
100a6f5
Merge remote-tracking branch 'origin/staging' into python312
daviddavo Jul 18, 2024
a7208e8
Updated conda in azureml tests
daviddavo Jul 18, 2024
94ccdeb
Update pymanopt usage
daviddavo Jul 18, 2024
cca9669
Use numpy 1.26.4 in Python 3.12
daviddavo Jul 18, 2024
12924d6
Merge branch 'staging' into python312
daviddavo Jul 31, 2024
5f02f45
Updated pymanopt in aml_utils
daviddavo Jul 31, 2024
18ff5b7
Relaxed numpy requirements
daviddavo Jul 31, 2024
913abde
Removed Python 3.8 tests
daviddavo Jul 31, 2024
3b0d1a1
Bumped required python version
daviddavo Jul 31, 2024
108c8a0
Upgraded azure python version to python 3.12
daviddavo Jul 31, 2024
2e2c99a
Updated tf-keras for new python versions
daviddavo Aug 1, 2024
8f0265a
Revert "Removed Python 3.8 tests"
daviddavo Aug 1, 2024
7705b5d
Revert "Bumped required python version"
daviddavo Aug 2, 2024
4d4779a
#2138 Using requirements-external to specify git deps
daviddavo Aug 2, 2024
1cbe6b6
Fixed conda env file
daviddavo Aug 2, 2024
734e4ac
Changed requirements-external order
daviddavo Aug 2, 2024
7b01eff
Install requirements-external.txt from GitHub
daviddavo Aug 2, 2024
8515dbf
Relaxed scipy version for Pyton 3.8
daviddavo Aug 2, 2024
4a544b2
Merge branch 'staging' into python312
daviddavo Aug 12, 2024
450bf17
Merge in staging
SimonYansenZhao Nov 12, 2024
9e00c0c
Solve merge conflict
miguelgfierro Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/azureml-cpu-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
strategy:
max-parallel: 50 # Usage limits: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration
matrix:
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"']
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"', '"python=3.12"']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the pr gate 3 times, and I got the same error with building the docker image:

    "error": ***
        "message": "Activity Failed:\n***\n    \"error\": ***\n        \"code\": \"UserError\",\n        \"message\": \"Image build failed. For more details, check log file azureml-logs/20_image_build_log.txt.\",\n        \"messageFormat\": \"Image build failed. For more details, check log file ***ArtifactPath***.\",\n        \"messageParameters\": ***\n            \"ArtifactPath\": \"azureml-logs/20_image_build_log.txt\"\n        ***,\n        \"details\": [],\n        \"innerError\": ***\n            \"code\": \"BadArgument\",\n            \"innerError\": ***\n                \"code\": \"ImageBuildFailure\"\n            ***\n        ***\n    ***,\n    \"correlation\": ***\n        \"operation\": \"e4090e90a11694fd527583a50e6946eb\",\n        \"request\": \"ce7a3c21a63c7552\"\n    ***,\n    \"environment\": \"eastus\",\n    \"location\": \"eastus\",\n    \"time\": \"2024-07-02T05:04:39.716946Z\",\n    \"componentName\": \"RunHistory\"\n***"

Could the problem be related to #2066 @SimonYansenZhao?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we access azureml-logs/20_image_build_log.txt? There are multiple reasons the BadArgument error might be raised.

Activity Failed:
***
    "error": ***
        "code": "UserError",
        "message": "Image build failed. For more details, check log file azureml-logs/20_image_build_log.txt.",
        "messageFormat": "Image build failed. For more details, check log file ***ArtifactPath***.",
        "messageParameters": ***
            "ArtifactPath": "azureml-logs/20_image_build_log.txt"
        ***,
        "details": [],
        "innerError": ***
            "code": "BadArgument",
            "innerError": ***
                "code": "ImageBuildFailure"
            ***
        ***
    ***,
    "correlation": ***
        "operation": "e4090e90a11694fd527583a50e6946eb",
        "request": "ce7a3c21a63c7552"
    ***,
    "environment": "eastus",
    "location": "eastus",
    "time": "2024-07-02T05:04:39.716946Z",
    "componentName": "RunHistory"
***

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelgfierro yeah, maybe.

test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
steps:
- name: Check out repository code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/azureml-gpu-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
strategy:
max-parallel: 50 # Usage limits: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration
matrix:
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"']
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"', '"python=3.12"']
test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
steps:
- name: Check out repository code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/azureml-spark-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
strategy:
max-parallel: 50 # Usage limits: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration
matrix:
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"']
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"', '"python=3.12"']
test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
steps:
- name: Check out repository code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/azureml-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
strategy:
max-parallel: 50 # Usage limits: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration
matrix:
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"']
python-version: ['"python=3.8"', '"python=3.9"', '"python=3.10"', '"python=3.11"', '"python=3.12"']
test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
steps:
- name: Check out repository code
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
[build-system]
requires = [
"setuptools>=52",
"setuptools>=67",
"wheel>=0.36",
"numpy>=1.15,<2",
]
dependencies = [
"setuptools>=52",
"setuptools>=67",
"wheel>=0.36",
"numpy>=1.15,<2",
]
Expand All @@ -17,4 +17,4 @@ markers = [
"gpu: tests running on GPU",
"notebooks: tests for notebooks",
"spark: tests that requires Spark",
]
]
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

install_requires = [
"category-encoders>=2.6.0,<3", # requires packaging
"cornac>=1.15.2,<2", # requires packaging, tqdm
"cornac>=1.15.2,<3", # requires packaging, tqdm
"hyperopt>=0.2.7,<1",
"lightgbm>=4.0.0,<5",
"locust>=2.12.2,<3", # requires jinja2
Expand Down Expand Up @@ -111,6 +111,7 @@
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Operating System :: POSIX :: Linux",
],
extras_require=extras_require,
Expand Down
Loading