Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2021 and 2022 data with aanalysis and updated streamlit app #316

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

NIKITA320495
Copy link
Contributor

No description provided.

Copy link
Member

@sanjay-kv sanjay-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @NIKITA320495

some suggestions for you would be : adding description on the changes made in the PR.
incoperating bit more coding comments. so it will improve readbility and understanding for future developments.

@sanjay-kv sanjay-kv merged commit a6b5d41 into recodehive:main Jul 4, 2024
1 check passed
Copy link

github-actions bot commented Jul 4, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@sanjay-kv
Copy link
Member

Could you check and reply here regarding the Streamlit app and Streamlit on Snowflakes are same thing? @NIKITA320495

@Leena2403
Copy link
Contributor

hello @sanjay-kv sir, please assign me the PR as well. As Nikita and I collaborated on this one as well. And yes, we'll make sure to add proper comments for readability from now on. As for Snowflakes, we never worked on it, so not sure.

@sanjay-kv
Copy link
Member

leena just raise one more PR and link the PR to there. and I will assign same level. it has been noted leaderboard is not fetching two people on co-authored commits.

  1. Raise an new PR by changing readme file
  2. Explain in the description you worked on this PR with links
  3. I will merge and give the same level @NIKITA320495 has got.

@Leena2403
Copy link
Contributor

Ok @sanjay-kv sir !

Leena2403 added a commit to Leena2403/Stackoverflow-Analysis that referenced this pull request Jul 9, 2024
This is a sample PR for the issue recodehive#316 (recodehive#316) that I collaborated on.

Due to some technical issues, my PR couldn't be merged, hence a sample merge is being created for fetching updated information on leaderboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants