Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow "ref" as valid prop, cleanup of Invalid_arguments and improve coverage #848

Closed
wants to merge 15 commits into from
Closed

Allow "ref" as valid prop, cleanup of Invalid_arguments and improve coverage #848

wants to merge 15 commits into from

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Jul 16, 2024

  • Allows to have a prop with ~ref
  • Took the chance to cleanup all raise Invalid_argument into Location.raise_errorf (which isn't ideal from the ppxlib standpoint, since it fails a Parseetree generation and only shows one error) but the refactor to this is massive.
    • I added tests for the Invalid_argument that I could reproduce and removed, but for the ones I couldn't I left them like they were before. I don't want to introduce a breaking change doing this work.
  • Took the chance to improve/fix this Very misleading error message if you misuse [@react.component] #843

davesnx added 14 commits July 16, 2024 16:23
@davesnx
Add test for error on key
bc5e467
@davesnx
Add locations into key
d12262d
@davesnx
Remove restriction for ref as prop
cfdd712
@davesnx
Format .re files from cram tests
8f846cc
@davesnx
Format all .re files
6f9b29a
@davesnx
Change message on key
8fd1780
@davesnx
Fix I#843 which improves error message on react.component wrongly placed
e706fb2
@davesnx
Apply same message on similar fn, update snapshot
d6a55d2
@davesnx
Add test for record-props and record-props-error
c4b1adc
@davesnx
Use caller to genreate uppercase
ae983fd
@davesnx
Remove Invalid_arguments
a23ff67
@davesnx
Add broken make_fn test and keep logic as before
152d64d
@davesnx
Merge branch 'main' of github.com:/reasonml/reason-react into ref-as-…
e00f56f 
…prop

* 'main' of github.com:/reasonml/reason-react:
  Add CSS Box Alignment Module Level 3 (#847)
  Remove type callback duplicate
  feat(react): add startTransition (#838)
  feat(react): add isValidElement (#837)
@davesnx
Install react@19
57eae9a
@davesnx davesnx marked this pull request as draft July 17, 2024 09:48
@davesnx davesnx closed this Nov 20, 2024
@davesnx davesnx mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davesnx