Feature/recording log version #1647
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeb01
force-pushed
the
feature/recording-log-version
branch
from
6d59038 to
7c3504b
Compare
mjpt777
approved these changes
Sep 6, 2024
aeron-cluster/src/test/java/io/aeron/cluster/RecordingLogVersioningTest.java
Outdated
Show resolved
Hide resolved
|
@mikeb01 do you want this feature to be merged as part of 1.47.0? |
No, does not need to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the RecordingLog file doesn't contain a header, we need to introduce a marker value (magic number) so that we can distinguish between the files with versioning and those without. This will check for that value and if not present will migrate the recording to the new structure (which includes a header that has a version field).