Landing page #114
Landing page #114
Conversation
aimun-naharr
commented
Jan 24, 2023
aimun-naharr
commented
✅ Deploy Preview for activities-reactplay ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks @aimunhidden485 for putting it together!
|
pages/index.js
Outdated
| useEffect(() => { | ||
| router.push('/hackrplay/2022/home'); | ||
| }, []); | ||
| // useEffect(() => { |
pages/index.js
Outdated
| // useEffect(() => { | ||
| // router.push('/hackrplay/2022/home'); | ||
| // }, []); | ||
| const recentEvent={ |
There was a problem hiding this comment.
Instead of two objects, have one array with all the events. Each of the event object should have name, description, image, link, isInProgress properties. If isInProgress true, then it is current, else false.
pages/index.js
Outdated
| const recentEvent={ | ||
| name: '#2PlaysAMonth', | ||
| description: 'Lorem ipsum dolor sit amet consectetur adipisicing elit. Corporis, debitis?' | ||
| } |
There was a problem hiding this comment.
We will get this array of event objects from DB in the future. For now, you can hardcode
components/Banner.js
Outdated
| @@ -0,0 +1,15 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const Banner = ({recentEvent}) => { | |||
There was a problem hiding this comment.
Change the name to CurrentInitiatives(even the file name)
yeah if I add more objects it would look like this |
|
Hello @aimunhidden485 Can you please make this one ready with resolving merge conflicts? |
okay I'm trying |
|
Closing this one as there is another PR raised by @aimunhidden485 |
