Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP 8.4+ support by avoiding implicitly nullable types #108

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

clue
Copy link
Member

@clue clue commented Jul 26, 2024

This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v0 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.

Builds on top of #105, #87, reactphp/promise#260, reactphp/stream#179 and reactphp/socket#318

@clue clue added this to the v0.7.0 milestone Jul 26, 2024
@clue clue requested a review from WyriHaximus July 26, 2024 11:51
@WyriHaximus WyriHaximus merged commit ce2654d into reactphp:0.7.x Aug 4, 2024
27 checks passed
@clue clue deleted the nullable branch August 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants