Remove redundant return in subscribe catch block #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aleexender Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
|
@Aleexender Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Aleexender Thank you for signing the Contributor License Agreement! |
chemicL
approved these changes
Jan 30, 2025
chemicL
requested changes
Jan 30, 2025
Remove redundant return statement in CorePublisher subscribe method The explicit return statement in the catch block is unnecessary since the method would naturally terminate after reporting the error through reportThrowInSubscribe. Signed-off-by: Aleexender <[email protected]>
it had a issue when i was using 23. but when i changed to jdk17 it was successfully worked! thanks! Signed-off-by: Aleexender <[email protected]>
Aleexender
force-pushed
the
cleanup-remove-redundant-return-reactive
branch
from
9712989 to
afaf054
Compare
|
@chemicL hello! I ran spotlessApply locally! Thank you for your help! |
chemicL
approved these changes
Feb 3, 2025
chemicL
added
the
type/chores
|
Thanks, @Aleexender :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant return statement in CorePublisher subscribe method
The explicit return statement in the catch block is unnecessary since the method would naturally terminate after reporting the error through reportThrowInSubscribe.
User Impact
Cleaner code with no behavioral changes for end users. This is purely a maintenance improvement that removes redundant code.
Technical Details
The catch block in the subscribe method contained an unnecessary explicit return statement after
Operators.reportThrowInSubscribe(). Since the method would naturally terminate after error reporting, this return statement was redundant and has been removed to improve code clarity.Related Issues
See #2072