This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Allow setting the Javascript scope for components #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act components are contained
| * The Javascript scope in which React components are contained (defaults to global) | ||
| * @var string | ||
| */ | ||
| $componentScope = 'global', |
There was a problem hiding this comment.
Seems fine but this should default to window. global is not defined by default.
Or perhaps even better, we don't define a default and if it's not set, then we don't try to use it.
Also nit here and other comments: ""JavaScript", not "Javascript".
18601673727
added a commit
to 18601673727/react-php-v8js
that referenced
this pull request
Dec 16, 2015
|
This is a thing I would like to do too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems ugly to have to place components in the global scope. How about this method to allow for setting the JavaScript scope in which React components are contained?