Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Changed spelling on cancel (#90) #129

Closed
wants to merge 4 commits into from
Closed

[WIP] Changed spelling on cancel (#90) #129

wants to merge 4 commits into from

Conversation

RLittlesII
Copy link
Member

@RLittlesII RLittlesII commented Aug 3, 2018

Resolves #90

@glennawatson
Copy link
Contributor

Are we doing American english or British english? Seems single L is American english.

@glennawatson
Copy link
Contributor

This is something that came up before when I was editing one of Geoff media announcements, eg which form of English we should use since he was using Australian english. We should probably document a standard in that regards.

@RLittlesII
Copy link
Member Author

RLittlesII commented Aug 3, 2018

I am not sure which version of English we should go with. In this specific instance, it is odd (and I've had this conversation with other devs) that the .NET Framework delivered CancellationToken is spell with two l's, but everything in the file that references cancelation is spelled with one.

That said, I'll defer this until we verify what our standard English will be, but I think that is a horse of a different colour. 😉

@glennawatson
Copy link
Contributor

This is waiting on reactiveui/rfcs#11 to resolve.

@glennawatson glennawatson changed the title Changed spelling on cancel (#90) [WIP] Changed spelling on cancel (#90) Aug 3, 2018
@glennawatson
Copy link
Contributor

This has changed so much since you've done that due to @worldbeater changes, should we take this up again in the main documentation?

@RLittlesII
Copy link
Member Author

@glennawatson I am going to close this, as the RFC is leaning towards leaving the spellings the way they are anyway.

@RLittlesII RLittlesII closed this Aug 24, 2018
@RLittlesII RLittlesII deleted the GH90 branch December 27, 2018 06:21
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with docs/handbook/commands/canceling.md
2 participants