fix: support -/@ symbols in csproj names #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
==========================================
- Coverage 87.73% 84.94% -2.80%
==========================================
Files 33 36 +3
Lines 2348 2504 +156
Branches 294 364 +70
==========================================
+ Hits 2060 2127 +67
- Misses 208 299 +91
+ Partials 80 78 -2 ☔ View full report in Codecov by Sentry. |
TimothyMakkison
force-pushed
the
unique_name_kebab
branch
from
dfe853f
to
78b7459
Compare
TimothyMakkison
changed the title
TimothyMakkison
changed the title
TimothyMakkison
force-pushed
the
unique_name_kebab
branch
from
78b7459
to
7d3b00a
Compare
TimothyMakkison
changed the title
TimothyMakkison
force-pushed
the
unique_name_kebab
branch
from
b0205b4
to
2c460c9
Compare
TimothyMakkison
force-pushed
the
unique_name_kebab
branch
from
2c460c9
to
744d4df
Compare
ChrisPulman
approved these changes
Nov 8, 2024
TimothyMakkison
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
-/@with_. inrefitInternalNamespace.Do you know what characters csproj supports?
Fixes #1920