housekeeping: Add ReactiveCommand usage examples #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1919 +/- ##
=======================================
Coverage 66.67% 66.67%
=======================================
Files 110 110
Lines 4372 4372
Branches 578 578
=======================================
Hits 2915 2915
Misses 1287 1287
Partials 170 170
Continue to review full report at Codecov.
|
|
Hey @worldbeater! Thank you for one more PR :) One question, instead of using |
But mention both aproaches.
giusepe
approved these changes
Jan 18, 2019
glennawatson
approved these changes
Jan 18, 2019
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
* housekeeping: Add ReactiveCommand usage examples * Prefer InvokeCommand() over Execute() But mention both aproaches. * Remove trailing whitespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR adds usage examples to ReactiveCommand API docs. Addresses reactiveui/rfcs#5 (comment)
What is the current behavior? (You can also link to an open issue here)
There are no examples in our API docs showing up how to create and execute a command.
What is the new behavior?
Examples are present.