Add Tests for Source Generators #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObservableAsProperty Reactive ReactiveCommand
src/ReactiveUI.SourceGenerator.Tests/ReactiveUI.SourceGenerator.Tests.csproj
Show resolved
Hide resolved
| if (ignoreConditional is not null) | ||
| { | ||
| var diagnostics = compilation.GetDiagnostics().ToList(); | ||
| diagnostics.Where(x => !ignoreConditional(x)).Should().BeEmpty(); | ||
| prediagnostics.Where(x => !ignoreConditional(x)).Should().BeEmpty(); |
There was a problem hiding this comment.
prediagnostics should fail most of the time, since the source generated code you rely on isn't there.
There was a problem hiding this comment.
Having Diagnostics fail the test helped in the diagnosis of the Test code, and enabled visibility of what needed to be masked
glennawatson
approved these changes
Oct 20, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests
What is the current behavior?
No tests
What is the new behavior?
ObservableAsProperty
Reactive
ReactiveCommand
These generators now have tests
What might this PR break?
None
Please check if the PR fulfills these requirements
Other information:
ObservableAsProperty does not recognise PropertyName property in test, this may be due to it being a string with a raw literal