Feature/maui cinephile #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabond251
commented
Feb 18, 2023
ChrisPulman
approved these changes
Sep 2, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add sample MAUI Cinephile
What is the current behavior?
No MAUI sample
What is the new behavior?
MAUI sample based on the Xamarin.Forms Cinephile app
What might this PR break?
The long-standing dearth of MAUI samples... also updated the DTOs in
Xamarin/Cinephile/Cinephile.Core/Rest/Dtosto useSystem.Text.Json.Serialization.JsonPropertyNameinstead ofNewtonsoft.Json.JsonProperty, since per the Refit README:Please check if the PR fulfills these requirements
Other information:
Please check if this is a good representation of using both RxUI and MAUI, individually and integrated. New to both and want to give/have a good starting point.