Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update valibot dependency to v1 #717

Merged

Conversation

fabian-hiller
Copy link
Contributor

I've updated the Valibot dependency for the React Hook Form resolver to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.


An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod resolver may no longer be necessary.

Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluebill1049
Copy link
Member

@fabian-hiller there is no breaking change with this v1 correct?

@fabian-hiller
Copy link
Contributor Author

There is. But only the type signature. So users will see a TS error if they try to use Valibot v1 beta with the old adapter.

@bluebill1049 bluebill1049 merged commit 37c3f78 into react-hook-form:master Oct 6, 2024
4 checks passed
Copy link
Contributor

🎉 This PR is included in version 3.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants