fix: set should support number directly

react-component · Dec 27, 2019 · 5e68ca4 · 5e68ca4
1 parent baade3e
commit 5e68ca4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/utils/set.ts b/src/utils/set.ts
@@ -7,11 +7,17 @@ export default function set<Entity = any, Output = Entity, Value = any>(
     return (value as unknown) as Output;
   }
 
-  const clone = ((Array.isArray(entity)
-    ? [...entity]
-    : { ...entity }) as unknown) as Output;
-
   const [path, ...restPath] = paths;
+
+  let clone: Output;
+  if (!entity && typeof path === 'number') {
+    clone = ([] as unknown) as Output;
+  } else if (Array.isArray(entity)) {
+    clone = ([...entity] as unknown) as Output;
+  } else {
+    clone = ({ ...entity } as unknown) as Output;
+  }
+
   clone[path] = set(clone[path], restPath, value);
 
   return clone;

diff --git a/tests/utils.test.js b/tests/utils.test.js
@@ -46,7 +46,7 @@ describe('utils', () => {
       [[[['light']]]],
     ]);
     expect(set([[[[[0]]]]], [0, 0, 0, 0, 0, 0], 'bamboo')).toEqual([
-      [[[[{ 0: 'bamboo' }]]]],
+      [[[[['bamboo']]]]],
     ]);
   });
 });