-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: The fixed attribute does not take effect #1193
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Walkthrough此次更改涉及 Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
搞个测试用例 cover 一下 |
ok,稍等 |
看了下测试用例,没考虑到expandIconColumnIndex小于0时是不渲染的,修改了一下判断条件 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
+ Coverage 97.70% 97.73% +0.02%
==========================================
Files 75 75
Lines 7420 7422 +2
Branches 1112 1114 +2
==========================================
+ Hits 7250 7254 +4
+ Misses 164 162 -2
Partials 6 6 ☔ View full report in Codecov by Sentry. |
佬,这个pr为啥还不给合并捏 |
@@ -176,9 +176,13 @@ function useColumns<RecordType>( | |||
// >>> Insert expand column if not exist | |||
if (!cloneColumns.includes(EXPAND_COLUMN)) { | |||
const expandColIndex = expandIconColumnIndex || 0; | |||
if (expandColIndex >= 0) { | |||
console.log(expandColIndex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删除调试语句
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
最好还是单独给个用例,单看 snap 的改变不容易看出是不是符合预期。 |
哦哦,明白鸟 |
修复表格expandable中设置fixed:right不生效,issues:ant-design/ant-design#50846
对于fixed的处理不正确,一个是判断逻辑有问题,fixed不应该和expandIconColumnIndex一起判断,一个是插入扩展列的时候没有按照fixed的值来处理
Summary by CodeRabbit