-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 FIX: virtual list direction aware #1188
🐛 FIX: virtual list direction aware #1188
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此次更改涉及在 Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/VirtualTable/BodyGrid.tsx (3 hunks)
Additional comments not posted (1)
src/VirtualTable/BodyGrid.tsx (1)
234-234
: 核实VirtualList
组件如何处理direction
属性。
direction
属性已正确传递给VirtualList
组件,这是实现 RTL 支持的关键步骤。建议核实VirtualList
组件是否正确处理了这一属性。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 75 75
Lines 7417 7420 +3
Branches 1112 1112
=======================================
+ Hits 7247 7250 +3
Misses 164 164
Partials 6 6 ☔ View full report in Codecov by Sentry. |
issue fix #1185
Summary by CodeRabbit
direction
属性,增强了组件处理布局或方向相关功能的能力。direction
调整其渲染逻辑,可能影响用户交互或视觉呈现。