Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple pub sub integration #113

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Simple pub sub integration #113

wants to merge 7 commits into from

Conversation

kschrief
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ jbigel
❌ kschrief
❌ kdivya153
❌ jbigel277
You have signed the CLA already but the status is still pending? Let us recheck it.

@rdkcmf-jenkins
Copy link

Coverity detected 2 issues; a quality concern.

};
requestMap.params.intent.data = data;
}

// Add the PubSub URL if required
if (getEnvVariable(CONSTANTS.PUB_SUB_URL, false)) {
data.query.params[CONSTANTS.PUB_SUB_URL] = getEnvVariable(CONSTANTS.PUB_SUB_URL);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium impact. Quality issue.
Null pointer dereferences. Bad use of null-like value.
Performing an operation that would be invalid on a null or undefined value.
If the value is null or undefined, this code will cause an exception such as a TypeError.

}

// Stringify the query (The intent requires it be a string)
data.query = JSON.stringify(data.query);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium impact. Quality issue.
Null pointer dereferences. Bad use of null-like value.
Performing an operation that would be invalid on a null or undefined value.
If the value is null or undefined, this code will cause an exception such as a TypeError.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  706:53  error  Parsing error: Unexpected token {

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  706:53  error  Parsing error: Unexpected token {

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants