-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple pub sub integration #113
base: dev
Are you sure you want to change the base?
Conversation
|
Coverity detected 2 issues; a quality concern. |
}; | ||
requestMap.params.intent.data = data; | ||
} | ||
|
||
// Add the PubSub URL if required | ||
if (getEnvVariable(CONSTANTS.PUB_SUB_URL, false)) { | ||
data.query.params[CONSTANTS.PUB_SUB_URL] = getEnvVariable(CONSTANTS.PUB_SUB_URL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium impact. Quality issue.
Null pointer dereferences. Bad use of null-like value.
Performing an operation that would be invalid on a null or undefined value.
If the value is null or undefined, this code will cause an exception such as a TypeError.
} | ||
|
||
// Stringify the query (The intent requires it be a string) | ||
data.query = JSON.stringify(data.query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium impact. Quality issue.
Null pointer dereferences. Bad use of null-like value.
Performing an operation that would be invalid on a null or undefined value.
If the value is null or undefined, this code will cause an exception such as a TypeError.
Issue with linting or unit tests detected.
For more information on our linting policies, please see our Linting-Guide. |
Issue with linting or unit tests detected.
For more information on our linting policies, please see our Linting-Guide. |
No description provided.