Fixing warnings and adding warnings to the local build

rdkcentral · Aug 22, 2023 · c06ab39 · c06ab39
1 parent e3e3411
commit c06ab39
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 8 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -26,5 +26,27 @@ if (BUILD_REFERENCE)
     add_definitions (-DBUILD_REFERENCE=${BUILD_REFERENCE})
 endif()
 
+option(ENABLE_STRICT_COMPILER_SETTINGS
+    "Enable compiler flags to get the warnings/errors due to improper condition in the code" ON)
+
+if(ENABLE_STRICT_COMPILER_SETTINGS)
+    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        message(FATAL_ERROR "Compiling with Clang")
+        set(CMAKE_STRICT_COMPILER_SETTINGS "-Weverything -Wextra -Wpedantic -Werror")
+        set(CMAKE_STRICT_CXX_COMPILER_SETTINGS "${CMAKE_STRICT_COMPILER_SETTINGS} -Wnon-virtual-dtor")
+    elseif(${CMAKE_COMPILER_IS_GNUCXX})
+        message(STATUS "Compiling with GCC")
+        set(CMAKE_STRICT_COMPILER_SETTINGS "-Wall -Wextra -Wpedantic -Werror")
+        set(CMAKE_STRICT_CXX_COMPILER_SETTINGS "${CMAKE_STRICT_COMPILER_SETTINGS} -Wnon-virtual-dtor")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+        message(STATUS "Compiling with MS Visual Studio")
+        set(CMAKE_STRICT_COMPILER_SETTINGS "/W4")
+    else()
+        message(STATUS "Compiler ${CMAKE_CXX_COMPILER_ID}")
+    endif()
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_STRICT_CXX_COMPILER_SETTINGS}")
+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${CMAKE_STRICT_COMPILER_SETTINGS}")
+endif()
+
 add_subdirectory(interfaces)
 add_subdirectory(definitions)
diff --git a/definitions/Definitions.cpp b/definitions/Definitions.cpp
@@ -83,7 +83,7 @@
 #include "ValuePoint.h"
 #endif
 
-MODULE_NAME_DECLARATION(BUILD_REFERENCE);
+MODULE_NAME_DECLARATION(BUILD_REFERENCE)
 
 namespace WPEFramework {
 

diff --git a/definitions/definitions.h b/definitions/definitions.h
@@ -47,10 +47,10 @@
 
 namespace WPEFramework {
 
-	ENUM_CONVERSION_HANDLER(Exchange::IComposition::ScreenResolution);
-	ENUM_CONVERSION_HANDLER(Exchange::IStream::streamtype);
-	ENUM_CONVERSION_HANDLER(Exchange::IStream::state);
-	ENUM_CONVERSION_HANDLER(Exchange::IValuePoint::basic);
-	ENUM_CONVERSION_HANDLER(Exchange::IValuePoint::specific);
-	ENUM_CONVERSION_HANDLER(Exchange::IValuePoint::dimension);
+	ENUM_CONVERSION_HANDLER(Exchange::IComposition::ScreenResolution)
+	ENUM_CONVERSION_HANDLER(Exchange::IStream::streamtype)
+	ENUM_CONVERSION_HANDLER(Exchange::IStream::state)
+	ENUM_CONVERSION_HANDLER(Exchange::IValuePoint::basic)
+	ENUM_CONVERSION_HANDLER(Exchange::IValuePoint::specific)
+	ENUM_CONVERSION_HANDLER(Exchange::IValuePoint::dimension)
 }
diff --git a/interfaces/json/ExternalMetadata.h b/interfaces/json/ExternalMetadata.h
@@ -57,5 +57,5 @@ namespace WPEFramework {
         }
     }
 
-	ENUM_CONVERSION_HANDLER(Exchange::External::Metadata::protocol);
+	ENUM_CONVERSION_HANDLER(Exchange::External::Metadata::protocol)
 }