feat: RPPL-2681 thunderBroker migration workaround changes #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| fn prepare_request(&self, request: &ThunderAsyncRequest) -> Result<Vec<String>, RippleError> { |
There was a problem hiding this comment.
Do you have any documentation related to the new changes ? Is ThunderBroker a singleton object ? If not, I have concern about multiple instances of ThunderBroker. In that case you may need to separate state management instance out of Thunder Broker.
I have also cleaned up prepare_request in the original implementation. Thunder Plugin state checking and activation have been moved to check_and_generate_plugin_activation_request helper function,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
thunderBroker migration changes added.
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist