Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPPL-2593 Device.uid is returning a value that contains dash (#633) (… #660

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

sakshihcst
Copy link
Contributor

…… (#657)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (#656)

  • fix: implement rpc_overriddes

  • build: cleanup

  • build: cleanup

  • fix: remove algorithm

  • build: cleanup

  • fix: cleanup device.uid after implementing legacy.device.uid in badger

  • fix: clippy errors

  • build: cleanup

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

#657)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (#656)

* fix: implement rpc_overriddes

* build: cleanup

* build: cleanup

* fix: remove algorithm

* build: cleanup

* fix: cleanup device.uid after implementing legacy.device.uid in badger

* fix: clippy errors

* build: cleanup

Co-authored-by: Suresh <[email protected]>
@sakshihcst sakshihcst requested review from a team October 17, 2024 17:45
Copy link

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src.processors 10%
core.tdk.src.utils 0%
core.sdk.src.api.gateway 87%
core.main.src.bootstrap.extn 0%
core.main.src.firebolt 4%
core.main.src.utils 27%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.state 26%
core.main.src.service 31%
core.main.src.broker 44%
core.main.src.processor.storage 0%
core.sdk.src.api.observability 68%
device.thunder.src 0%
device.thunder_ripple_sdk.src 15%
core.main.src.bootstrap 0%
distributor.general.src 2%
core.main.src.firebolt.handlers 8%
core.sdk.src.framework 75%
core.main.src.bootstrap.manifest 0%
device.thunder_ripple_sdk.src.processors.events 0%
device.thunder_ripple_sdk.src.client 74%
core.sdk.src.api 78%
core.sdk.src.api.distributor 84%
core.main.src.processor 0%
core.tdk.src.gateway 100%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.events 4%
core.launcher.src 0%
core.main.src.service.extn 40%
core.main.src.state.cap 44%
core.main.src.broker.thunder 54%
core.sdk.src.utils 53%
core.main.src.service.apps 47%
core.main.src 0%
device.mock_device.src 52%
core.sdk.src.api.manifest 91%
core.launcher.src.manager 7%
core.sdk.src.api.firebolt 78%
core.sdk.src.extn.client 91%
core.sdk.src.api.device 77%
core.sdk.src.extn.ffi 80%
openrpc_validator.src 90%
core.sdk.src.extn 83%
Summary 44% (17915 / 40977)

Minimum allowed line rate is 42%

@sakshihcst sakshihcst merged commit 62d80a8 into 1.12.rc Oct 17, 2024
7 checks passed
@sakshihcst sakshihcst deleted the 1.12.rppl.2654 branch October 17, 2024 19:45
sakshihcst added a commit that referenced this pull request Oct 17, 2024
#660)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (… (#657)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (#656)

* fix: implement rpc_overriddes

* build: cleanup

* build: cleanup

* fix: remove algorithm

* build: cleanup

* fix: cleanup device.uid after implementing legacy.device.uid in badger

* fix: clippy errors

* build: cleanup

Co-authored-by: Suresh <[email protected]>
sakshihcst added a commit that referenced this pull request Oct 18, 2024
RPPL-2593 Device.uid is returning a value that contains dash (#633) (… (#660)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (… (#657)

RPPL-2593 Device.uid is returning a value that contains dash (#633) (#656)

* fix: implement rpc_overriddes

* build: cleanup

* build: cleanup

* fix: remove algorithm

* build: cleanup

* fix: cleanup device.uid after implementing legacy.device.uid in badger

* fix: clippy errors

* build: cleanup

Co-authored-by: Suresh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants