Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create rules for Authentication and Account modules #658

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

maggie98choy
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@maggie98choy maggie98choy requested a review from a team October 16, 2024 21:18
@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/658/rdkcentral/Ripple

  • Commit: f29b3c2

Report detail: gist'

@maggie98choy maggie98choy force-pushed the create-rules-for-Authentication-Account-Modules branch from f29b3c2 to b5daac6 Compare October 16, 2024 21:35
@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/658/rdkcentral/Ripple

  • Commit: b5daac6

Report detail: gist'

@rdkcmf-jenkins
Copy link

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: OK

  • Commit: b5daac6
    '

@maggie98choy maggie98choy force-pushed the create-rules-for-Authentication-Account-Modules branch from b5daac6 to a4a09e5 Compare October 17, 2024 16:35
@maggie98choy maggie98choy force-pushed the create-rules-for-Authentication-Account-Modules branch from a4a09e5 to a2a866c Compare October 23, 2024 23:33
@maggie98choy maggie98choy force-pushed the create-rules-for-Authentication-Account-Modules branch from 5f8e0fc to 870c369 Compare October 25, 2024 17:46
Copy link

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src 15%
core.main.src.utils 26%
device.thunder_ripple_sdk.src.client 74%
core.main.src 0%
device.thunder.src 0%
openrpc_validator.src 80%
core.main.src.service.extn 40%
core.main.src.processor.storage 0%
core.sdk.src.framework 75%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.broker 50%
core.main.src.firebolt 3%
core.tdk.src.gateway 100%
core.sdk.src.api.distributor 84%
core.sdk.src.extn.client 91%
core.sdk.src.extn 83%
core.main.src.bootstrap.extn 0%
core.main.src.state 23%
core.sdk.src.api 78%
core.sdk.src.api.gateway 85%
core.main.src.broker.thunder 22%
core.launcher.src 0%
core.main.src.bootstrap 0%
core.sdk.src.api.device 77%
core.main.src.state.cap 43%
core.main.src.bootstrap.manifest 0%
core.main.src.firebolt.handlers 9%
core.main.src.service 31%
core.sdk.src.extn.ffi 80%
device.thunder_ripple_sdk.src.events 4%
device.thunder_ripple_sdk.src.processors 10%
core.sdk.src.api.observability 68%
core.tdk.src.utils 0%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors.events 0%
core.sdk.src.api.manifest 91%
core.sdk.src.api.firebolt 77%
core.launcher.src.manager 7%
core.sdk.src.utils 53%
device.mock_device.src 52%
core.main.src.processor 0%
distributor.general.src 2%
core.main.src.service.apps 47%
Summary 43% (18378 / 42573)

Minimum allowed line rate is 42%

@tfarz123 tfarz123 requested a review from a team October 25, 2024 19:33
@maggie98choy maggie98choy merged commit ce96f61 into main Oct 25, 2024
7 checks passed
@maggie98choy maggie98choy deleted the create-rules-for-Authentication-Account-Modules branch October 25, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants