RPPL-2651: Ripple Event warning should not print for context events #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahearn73
reviewed
Oct 8, 2024
pahearn73
approved these changes
Oct 8, 2024
satlead
reviewed
Oct 14, 2024
| let is_ripple_context = | ||
| RippleContext::is_ripple_context(&message.payload).is_none(); | ||
|
|
||
| if self.has_event_listener(&message.target.as_clear_string()) { |
There was a problem hiding this comment.
Please add a negation here it should not proceed to send the ripple context if there are any listeners
There was a problem hiding this comment.
added the change please have a look
… notifying. chore: removed the ripple context update from get_timezone_and_offset() which is unnecessary.
satlead
approved these changes
Oct 24, 2024
satlead
reviewed
Nov 5, 2024
| @@ -1116,16 +1116,6 @@ impl ThunderDeviceInfoRequestProcessor { | |||
|
|
|||
| // If timezone or offset is None or empty | |||
| if let Some(tz) = Self::get_timezone_and_offset(&state).await { | |||
| let cloned_state = state.clone(); | |||
There was a problem hiding this comment.
We get the Timezone and set it in Ripple context here. This sets up the initial context until the point the user changes the timezone. Are we removing this because it is adding that log?
There was a problem hiding this comment.
@SDK, I removed it because i understood like, that cause's the warning log. I'll revert this change.
Minimum allowed line rate is |
pahearn73
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add check for event listener's for context events.
Why
if there are no event listeners available then no need to warn
How
added check for event listeners availability based on that print the warn!
Test
if context event listeners available then warn! msg prints if not then warn! msg wont print.
Checklist