Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Handshake does not appear in the first, TLS cannot be recognized #284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LQchengdu
Copy link

No description provided.

@LQchengdu
Copy link
Author

Handshake messages for some TLS packets, not always the first, like this
image

@jtesta
Copy link
Contributor

jtesta commented Aug 31, 2023

@LQchengdu : is there a publicly-available host that exhibits this behavior? If so, I'd like to test against it. Thanks!

@LQchengdu
Copy link
Author

@jtesta Thanks for your reply, you can try www.vecentek.com:443

@jtesta
Copy link
Contributor

jtesta commented Sep 2, 2023

Aside from the changes requested above, I see that this patch causes failures in the Docker tests:

$ ./docker_test.sh 

Docker image sslscan-test:3 already exists.

Running all tests...
Test #1 passed.
Test #2 FAILED.

--- docker_test/expected_output/test_2.txt	2023-09-01 20:49:16.266096461 -0400
+++ /tmp/sslscan_test-results_RY5sr9C1N4/test_2.txt	2023-09-01 20:49:34.570260076 -0400
@@ -23,5 +23,9 @@
   Heartbleed:
 
   Supported Server Cipher(s):
+    Unable to parse certificate
+    Unable to parse certificate
+    Unable to parse certificate
+    Unable to parse certificate
 Certificate information cannot be retrieved.
 

Test #3 FAILED.

--- docker_test/expected_output/test_3.txt	2023-09-01 20:49:16.266096461 -0400
+++ /tmp/sslscan_test-results_RY5sr9C1N4/test_3.txt	2023-09-01 20:49:35.602269302 -0400
@@ -23,5 +23,9 @@
   Heartbleed:
 
   Supported Server Cipher(s):
+    Unable to parse certificate
+    Unable to parse certificate
+    Unable to parse certificate
+    Unable to parse certificate
 Certificate information cannot be retrieved.
 

Test #4 passed.
Test #5 passed.
Test #6 passed.
Test #7 passed.
Test #8 passed.
Test #9 skipped.
Test #10 skipped.
Test #11 passed.
Test #12 passed.
Test #13 passed.
Test #14 passed.
Test #15 passed.
Test #16 passed.
Test #17 passed.
Test #18 passed.


!! SOME TESTS FAILED !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants