-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Interpolate missing nominal values during Averaging #246
base: master
Are you sure you want to change the base?
Conversation
@bennahugo would you consider giving this a quick review, mostly of the new test cases: Note that this doesn't change the BDA averaging code, yet. It only modifies the standard time and channel averaging code because it's far easier to reason about including X seconds worth of data in the bin. If you're happy with the standard case, I'll implement the same in the BDA code. |
Discussion Points
10 seconds bin O O O X X X X O | O O O | X X X X O | O O O | X X X X O | -- current strategy, samples completely in/out of a bin | O O O | X X X X | O | |
Tests added / passed
If the pep8 tests fail, the quickest way to correct
this is to run
autopep8
and thenflake8
andpycodestyle
to fix the remaining issues.Fully documented, including
HISTORY.rst
for all changesand one of the
docs/*-api.rst
files for new APITo build the docs locally: