Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Gain smoothing (do not merge) #311

Open
wants to merge 85 commits into
base: main
Choose a base branch
from
Open

Conversation

landmanbester
Copy link
Collaborator

This is an attempt to smooth gain solutions using the NIFTy library. It is still rather experimental because it will only parallelise with the processes scheduler and is only really meant for bandpass smoothing at this stage. There is still a bit of work before this will be ready to be used in anger

JSKenyon and others added 30 commits July 26, 2023 11:15
… required. (#285)

* Fix version drift.

* Bump to 0.2.0

* Use nearest-neighbour interpolation for points requiring extrapolation.
* Fix version drift.

* Bump to 0.2.0

* Inspect envvar for scheduler address when one isn't specified.

* Encode environment varraible as ascii.

* Simplify.
* Fix version drift.

* Bump to 0.2.0

* Initial commit of basic plotting functionality.

* Change naming convention.

* Improve transform argument.

* Simplify transform selection.

* Add rudimentary time and frequency selection.

* Checkpoint ploter changes. Can now handle scans and spws, but is very slow.

* More work on plotter - can now plot datasets in parallel.

* Some tidying.

* Slightly improve plot speed. Dominant cost is still saving the figures.

* Commit some minor changes which speed up figure saving.

* Lots of tiny fixes.

* Tiny cosmetic changes.

* Add custom tick formatter so that plots are the same size regardless.

* Add matplotlib dependency.

* Rework construction of plotting dictionary. Add a few utility functions which will likely be useful in other places in QC.

* Rename variable to avoid confusion.

* Fix bug affecting recursive grouping.

* Avoid copies in grouping code.

* Checkpoint work on extending functionality.

* Make plotter more powerful. Add colourization option. Begin simplifying interface.

* Allow user specification of colourmap.

* Add plotsize parameter.
@landmanbester landmanbester changed the base branch from main to v0.2.1-dev November 13, 2023 07:37
Base automatically changed from v0.2.1-dev to main January 30, 2024 06:46
@JSKenyon JSKenyon changed the base branch from main to v0.2.2-dev January 30, 2024 08:52
@JSKenyon
Copy link
Collaborator

The v0.2.1-dev branch has been merged. This PR will need to be updated accordingly. Just shout if you need any help - I know it is irritating.

@JSKenyon
Copy link
Collaborator

Did a little digging - I think that this branch changes the function signature of add_calibration_graph. This will need to be taken into account in the test fixtures.

@bennahugo
Copy link
Collaborator

bennahugo commented Jan 31, 2024

mmm this will make quartical very hard to install on the range of machines we have - is it possible we can keep nifty as an optional dependency?

@landmanbester
Copy link
Collaborator Author

Yeah the signature has changed because I added the bypass_solver option. This is useful when smoothing and transferring gains because you don't have to crunch through all the vis data. I still need to modify the testing suite to account for this but at least I can pip install the branch again. @bennahugo I have just temporarily disabled 3.9 support because the dev branch of nifty I am depending on doesn't support it. I fully intent to support it before attempting to merge these changes

Base automatically changed from v0.2.2-dev to main February 2, 2024 11:21
@JSKenyon JSKenyon changed the base branch from main to v0.2.3-dev February 2, 2024 11:23
Base automatically changed from v0.2.3-dev to main April 22, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants