Rework of door position sync #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusmuja
commented
Oct 7, 2023
bdraco
reviewed
Oct 7, 2023
mariusmuja
force-pushed
the
door_position_sync
branch
from
0110077
to
55408d5
Compare
mariusmuja
commented
Oct 7, 2023
|
Looks good. Testing shortly |
…should get called when status message is received
|
Ran out of time to test today. Will try to pick it up tomorrow |
bdraco
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the door position sync to make it simpler and hopefully more accurate.
The way we show the door position in HA is by "simulating it", because we don't have any position feedback from the door opener. Currently we simulate it and hope for the best, but for example if there's anything that prevents the open/close command to be received the simulation will not match reality.
This updates the simulation to make it slightly more realistic, instead to triggering it when we send the open/close command we trigger it when the opening/closing status message is received from the opener. Also we use the actual time in the update closure instead of the scheduled time.