Add ID to OTA to allow extension for overrides #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently package yaml will override any settings, this allows you to do the following to add password, etc: ota: id: !extend ratgdo_ota password: "...."
bdraco
approved these changes
Jun 26, 2024
|
Thanks @notjj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how esphome handles inheritance, merging and replacing in packages[link], having ota: as part of the base package will override any changes a user may make in their own config.
So in the case of ota: if you have a password defined as below in their local config:
They will no longer be able to update as the package will overwrite the entire ota: section with what is in the base config, and result in the following error:
So the option is either disable the OTA password by plugging the device in to flash, or add an ID to allow !extend to work on the OTA settings.
With an ID added, a user can use !extend in their config to add additional settings, such as password
Hopefully this is just a short-term fix and esphome makes some changes upstream to resolve this... as the !extend function isn't commonly used (there is an issue open for it currently, but only 5hrs old).