[WIP] each slice when over 300 leads on createupdate/delete #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| params[:asyncProcessing] = async_processing if async_processing | ||
| # see also: http://developers.marketo.com/documentation/rest/createupdate-leads/ | ||
| # > You can update a maximum of 300 leads with a single API call. | ||
| leads.each_slice(MAX_LEADS_SIZE).map do |_leads| |
There was a problem hiding this comment.
Maybe you should flatten the output to not break the API with a new response type.
There was a problem hiding this comment.
the output to not break the API
Agree.
But when leads is over 300, we call multiple requests to marketo and receive multiple responses.
There was a problem hiding this comment.
But...I begin to thought that this method should be keep it simple.
There was a problem hiding this comment.
I see your point that's why I wrote that you should flatten the response, with #flat_map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Over 300 leads
http://developers.marketo.com/documentation/rest/createupdate-leads/
http://developers.marketo.com/documentation/rest/delete-lead/
fix exists specs
add specs for limit of lead size and payload size