Skip to content

Commit

Permalink
remove an unnecessary sync in exchange_embeddings_nccl_func (#143)
Browse files Browse the repository at this point in the history
Remove an unnecessary sync, which may lead to bad overlapping performance.

Authors:
  - https://github.com/linhu-nv

Approvers:
  - Chuang Zhu (https://github.com/chuangz0)

URL: #143
  • Loading branch information
linhu-nv authored Mar 12, 2024
1 parent daafc76 commit 73432c6
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ wholememory_error_code_t exchange_embeddings_nccl_func(const void* dev_local_gat
WHOLEMEMORY_DT_INT8,
stream);
WM_CUDA_DEBUG_SYNC_STREAM(stream);
WHOLEMEMORY_EXPECTS(wm_comm->sync_stream(stream) == WHOLEMEMORY_SUCCESS,
"Embedding AllToAllV failed.");
// WHOLEMEMORY_EXPECTS(wm_comm->sync_stream(stream) == WHOLEMEMORY_SUCCESS,
// "Embedding AllToAllV failed.");
} catch (wholememory::logic_error& wle) {
WHOLEMEMORY_ERROR("exchange_embeddings_nccl_func LOGIC Error %s\n", wle.what());
return WHOLEMEMORY_LOGIC_ERROR;
Expand Down

0 comments on commit 73432c6

Please sign in to comment.