Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CCCL 2.7.0-rc2. #313

Closed
wants to merge 1 commit into from
Closed

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 1, 2024

This PR updates to CCCL 2.7.0-rc2. Do not merge until all of RAPIDS is ready to update.

Part of rapidsai/build-planning#115.

@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Nov 1, 2024
@pentschev
Copy link
Member

Why do we need to explicitly add it to UCXX since it doesn't use it directly?

@bdice
Copy link
Contributor Author

bdice commented Nov 1, 2024

Ah, maybe I didn’t need this PR. I had ucxx in the list of repos from my last CCCL update automation and maybe this is a mistake. I’ll double check some things on my side and close if unnecessary.

@bdice
Copy link
Contributor Author

bdice commented Nov 1, 2024

I think previously, this repo was using RMM via CMake CPM, which would trigger RMM CMake logic and thus rapids-cmake's pinnings. That is why we previously we had test PRs for ucxx. However, now ucxx is using librmm wheels, so there isn't a way to trigger the RMM CMake logic directly (it finds the local librmm package and doesn't need to fetch CCCL).

For this migration, we could test upstream artifacts by fetching the librmm wheel from rapidsai/rmm#1715 and using it in this build. However, we think the risk of this migration is low, especially given the advances in CCCL-RAPIDS joint testing, so we are hoping that this migration can be done without the need to test with upstream artifacts. It takes significantly more effort to test with upstream artifacts.

I will close this PR and mark it as complete.

@bdice bdice closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants