Update and test _nx_cugraph._check_networkx_version
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
approved these changes
Nov 14, 2024
KyleFromNVIDIA
requested changes
Nov 18, 2024
| version_major, version_minor, *version_bug = nx.__version__.split(".")[:3] | ||
| if nx_version is None: | ||
| nx_version = nx.__version__ | ||
| version_major, version_minor, *version_bug = nx_version.split(".")[:3] |
There was a problem hiding this comment.
Instead of parsing manually, consider using packaging.version.Version (though this does add a dependency on packaging.)
There was a problem hiding this comment.
We had been using packaging.version.parse in tests, but this was removed in rapidsai/cugraph#4629 (a very large PR), and other discussions are in rapidsai/cugraph#4571.
What I like about doing this manually is that we have full control and can add functionality and tests whenever there is a regression, b/c although networkx versions are very predictable, sometimes dev versions can be formatted oddly. I expect this to be low-maintenance, and that we will catch issues very promptly.
#22 will also help us use the version tuple correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes handling of the current dev version of networkx
"3.5rc0.dev0":https://github.com/networkx/networkx/blob/5c3e8beef128f532b536d2d4a9f7e309ed53416b/networkx/__init__.py#L11
Also, add testing since this is becoming exercised.