Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang grco for CCCL #184

Open
wants to merge 4 commits into
base: branch-24.02
Choose a base branch
from
Open

Add clang grco for CCCL #184

wants to merge 4 commits into from

Conversation

wmaxey
Copy link
Contributor

@wmaxey wmaxey commented Dec 5, 2023

Addresses #183

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 5, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jrhemstad
Copy link
Collaborator

/ok to test

jrhemstad
jrhemstad reviewed Dec 5, 2023
View reviewed changes
features/src/llvm/install.sh
fi

echo "Installing NVIDIA Clang for Grace"
wget -O clang-grace-toolchain.deb https://developer.nvidia.com/downloads/assets/grace/clang/16.23.08/clang-grace-toolchain_16.23.08_arm64.deb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Are we okay hard coding the version for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see another version publicly. We can devise a mechanism later probably.

@jrhemstad
Copy link
Collaborator

/ok to test

jrhemstad
jrhemstad requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trxcllnt requested that we make clang.grco a separate feature instead of part of the existing llvm feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmaxey @jrhemstad