Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print sccache stats in builds #413

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 15, 2024

Description

Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

  • printing sccache stats to CI logs
  • reducing pip's verbosity in wheel building scripts
  • updating to the latest rapids-dependency-file-generator (v1.16.0)
  • always explicitly specifying cpp / python in calls to rapids-upload-wheels-to-s3
  • modifying dependencies.yaml to match RAPIDS-wide naming conventions

Notes for Reviewers

This originally also ran wheel builds with --no-build-isolation, but I reverted that based on rapidsai/build-planning#108 (comment).

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change DO NOT MERGE labels Oct 15, 2024
@github-actions github-actions bot added the ci label Oct 15, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] build wheels without build isolation WIP: [DO NOT MERGE] print sccache stats in builds Oct 29, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] print sccache stats in builds print sccache stats in builds Oct 29, 2024
@jameslamb jameslamb marked this pull request as ready for review October 29, 2024 18:20
@jameslamb jameslamb requested review from a team as code owners October 29, 2024 18:20
@jameslamb jameslamb requested a review from bdice October 29, 2024 18:20
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit d296d81 into rapidsai:branch-24.12 Oct 29, 2024
57 checks passed
@jameslamb jameslamb deleted the wheel-build-no-isolation branch October 29, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants