-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print sccache stats in builds #6111
Merged
rapids-bot
merged 17 commits into
rapidsai:branch-24.12
from
jameslamb:wheel-build-no-isolation
Oct 31, 2024
Merged
print sccache stats in builds #6111
rapids-bot
merged 17 commits into
rapidsai:branch-24.12
from
jameslamb:wheel-build-no-isolation
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
5 - DO NOT MERGE
Hold off on merging; see PR for details
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Oct 15, 2024
…into wheel-build-no-isolation
jameslamb
changed the title
WIP: [DO NOT MERGE] build wheels without build isolation
WIP: [DO NOT MERGE] print sccache stats in builds
Oct 29, 2024
jameslamb
changed the title
WIP: [DO NOT MERGE] print sccache stats in builds
print sccache stats in builds
Oct 29, 2024
bdice
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, otherwise LGTM
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#111
Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.
sccache
stats to CI logspip
's verbosity in wheel building scriptsrapids-dependency-file-generator
(v1.16.0)cpp
/python
in calls torapids-upload-wheels-to-s3
Notes for Reviewers
This originally also ran wheel builds with
--no-build-isolation
, but I reverted that based on rapidsai/build-planning#108 (comment).