Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Add basic common test infrastructure #6107

Open
wants to merge 3 commits into
base: branch-24.12
Choose a base branch
from

Conversation

betatim
Copy link
Member

@betatim betatim commented Oct 11, 2024

xref #6105

This adds a test that uses the test infrastructure that scikit-learn provides to find out if an estimator is compatible with scikit-learn. Short explanation https://scikit-learn.org/dev/developers/develop.html#rolling-your-own-estimator and we use https://scikit-learn.org/dev/modules/generated/sklearn.utils.estimator_checks.parametrize_with_checks.html#sklearn.utils.estimator_checks.parametrize_with_checks here to have a test that is parametrized by estimator and check. This makes it easy to see what is failing.

I've only added LogisticRegression for the moment, mostly because I wanted to see what other people think of this. I think it would be useful for issues like #6105 to find out which estimators are/aren't compatible, fix them and make sure they stay compatible. Fixing some of the failures would probably make it easier for users to swap scikit-learn and cuml without big effort. A downside is that right now a lot of the checks fail.

WDYT?

@betatim betatim requested a review from a team as a code owner October 11, 2024 13:03
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 11, 2024
@betatim
Copy link
Member Author

betatim commented Oct 16, 2024

It now iterates over all (or at least most?) estimators in cuml and checks them. Unfortunately a lot of the tests fail and locally I even get a rmm error which crashes pytest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant