Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-23.10 to branch-23.12 #5605

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-23.10 that creates a PR to keep branch-23.12 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

This PR fixes a few issues ran into while testing the different supported algorithms:

- Add pandas as runtime dependency (which already is of the GPU package through cuDF) 
- Use np.dtype as opposed to cp.dtype, they are the same object in the changes of the PR, and other similar changes to not trigger cudf/cupy/numba calls at import time, which cause runtime issues in some algos. 
- Other small fixes that can cause issues at runtime

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - William Hicks (https://github.com/wphicks)

URL: #5599
@GPUtester GPUtester requested review from a team as code owners October 4, 2023 22:12
@GPUtester GPUtester merged commit a4c9925 into branch-23.12 Oct 4, 2023
14 checks passed
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Oct 4, 2023
@GPUtester
Copy link
Contributor Author

SUCCESS - forward-merge complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue Cython / Python Cython or Python issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants