Increase the numerical tolerance for test_pairwise_distances tests. #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadorf
added
tests
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Pin the container-image for the CI clang-tidy check to a previous version as the latest change to move `rapidsai/ci:latest` to CUDA 12 seemingly broke the test. See this [log](https://github.com/rapidsai/cuml/actions/runs/5955794611/job/16155266993#step:9:1) for an example. Also includes: - #5562 - #5572 - #5575 Authors: - Simon Adorf (https://github.com/csadorf) - Divye Gala (https://github.com/divyegala) - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) Approvers: - William Hicks (https://github.com/wphicks) - Dante Gama Dessavre (https://github.com/dantegd) - AJ Schmidt (https://github.com/ajschmidt8) - Bradley Dice (https://github.com/bdice) URL: #5561
|
Closing now that #5561 has been merged, feel free to reopen if we still need it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the tolerance for the test_pairwise_distances tests. Previous tolerance was set too low resulting in spurious test failures. Addresses current test failures observed in CI.