Skip to content

Commit

Permalink
Make cuVS optional if CUML_ALGORITHMS is set (#6125)
Browse files Browse the repository at this point in the history
cuVS should not be required when building cuML with `CUML_ALGORITHMS=fil`.

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #6125
  • Loading branch information
hcho3 authored Nov 4, 2024
1 parent 27e47e5 commit a0186c7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 3 additions & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ endif()
include(cmake/thirdparty/get_cccl.cmake)
include(cmake/thirdparty/get_rmm.cmake)
include(cmake/thirdparty/get_raft.cmake)
include(cmake/thirdparty/get_cuvs.cmake)
if(LINK_CUVS)
include(cmake/thirdparty/get_cuvs.cmake)
endif()

if(LINK_TREELITE)
include(cmake/thirdparty/get_treelite.cmake)
Expand Down
8 changes: 7 additions & 1 deletion cpp/cmake/modules/ConfigureAlgorithms.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#=============================================================================
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -20,6 +20,7 @@ if(CUML_ALGORITHMS STREQUAL "ALL")
set(CUML_RAFT_COMPILED ON)
set(LINK_TREELITE ON)
set(LINK_CUFFT ON)
set(LINK_CUVS ON)
set(all_algo ON)
# setting treeshap to ON to get the gputreeshap include in the cuml_cpp_target
set(treeshap_algo ON)
Expand Down Expand Up @@ -122,5 +123,10 @@ else()
if(metrics_algo)
set(CUML_RAFT_COMPILED ON)
endif()

if(dbscan_algo OR hdbscan_algo OR kmeans_algo OR knn_algo
OR metrics_algo OR tsne_algo OR umap_algo)
set(LINK_CUVS ON)
endif()
endif()

0 comments on commit a0186c7

Please sign in to comment.