enforce wheel size limits, README formatting in CI #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
changed the title
bdice
approved these changes
Nov 14, 2024
python/cugraph/pyproject.toml
Outdated
| ] | ||
|
|
||
| # detect when package size grows significantly | ||
| max_allowed_size_compressed = '1.5G' |
There was a problem hiding this comment.
Should we do what @betatim proposed for cuml here (and in pylibcugraph) as well, and have separate CUDA 11/12 limits?
There was a problem hiding this comment.
Yeah with the benefit of a night of sleep, I do think that's better and the little bit of extra complexity in the script is worth it. I'll do that here.
And put up a PR in cuvs doing that too... it had a similar huge threshold + huge difference across CUDA versions.
There was a problem hiding this comment.
Just put up a proposal for setting these thresholds, let me know what you think.
|
/merge |
This was referenced Nov 14, 2024
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Nov 15, 2024
`cuvs-cu11` wheels are significantly larger than `cuvs-cu12` wheels, because (among other reasons) they are not able to dynamically link to CUDA math library wheels. In #464, I proposed a size limit for CI checks of "max CUDA 11 wheel size + a buffer". This PR proposes using different thresholds based on CUDA major version, following these discussions: * rapidsai/cugraph#4754 (comment) * rapidsai/cuml#6136 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mike Sarahan (https://github.com/msarahan) URL: #469
BradReesWork
pushed a commit
to BradReesWork/cugraph
that referenced
this pull request
Nov 18, 2024
Contributes to rapidsai/build-planning#110 Proposes adding 2 types of validation on wheels in CI, to ensure we continue to produce wheels that are suitable for PyPI. * checks on wheel size (compressed), - *to be sure they're under PyPI limits* - *and to prompt discussion on PRs that significantly increase wheel sizes* * checks on README formatting - *to ensure they'll render properly as the PyPI project homepages* - *e.g. like how https://github.com/scikit-learn/scikit-learn/blob/main/README.rst becomes https://pypi.org/project/scikit-learn/* This intentionally omits the libraries that are about to be moved to other repos. * `cugraph-dgl` / `cugraph-pyg` (rapidsai/cugraph-gnn#67) * `nx-cugraph` (rapidsai/nx-cugraph#19) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: rapidsai#4754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#110
Proposes adding 2 types of validation on wheels in CI, to ensure we continue to produce wheels that are suitable for PyPI.
Notes for Reviewers
This intentionally omits the libraries that are about to be moved to other repos.
cugraph-dgl/cugraph-pyg(enforce wheel size limits, README formatting in CI cugraph-gnn#67)nx-cugraph(enforce wheel size limits, README formatting in CI nx-cugraph#19)