Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address primitives performance regression with the added edge masking support (when edge masking is not in use) #4119

Merged
merged 29 commits into from
Feb 9, 2024
Merged

Address primitives performance regression with the added edge masking support (when edge masking is not in use) #4119

merged 29 commits into from
Feb 9, 2024

Conversation

seunghwak
Copy link
Contributor

This addresses performance regression due to the added edge masking support when edge masking is disabled.

We addressed the issue for per_v_transform_reduce_incoming|outgoing_e in #4085

Using a similar approach, we address the issue for transform_e, transform_reduce_e, and detail::nbr_intersection in this PR.

@seunghwak
update tests to include edge masking
a36eb62
@seunghwak
remove unnecessary multiply by 1.0
8bdc17e
@seunghwak
update to support edge masking
9751332
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
a2e99fb 
…to fea_per_v_transform_reduce_edge_mask
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
a3adff9 
…to fea_per_v_transform_reduce_edge_mask
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
b646a10 
…to fea_per_v_transform_reduce_edge_mask
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
4e4b72b 
…to fea_per_v_transform_reduce_edge_mask
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
050b78a 
…to fea_per_v_transform_reduce_edge_mask
@seunghwak
rename call_e_op_t to transform_reduce_v_froniter_call_e_op_t to avoi…
3782e1b 
…d name collision
@seunghwak
fewer checking for edge_partition_e_mask.has_value() if edge masking …
23874af 
…is disabled
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
5e611c6 
…to fea_per_v_transform_reduce_edge_mask
@seunghwak
copyright year
65104df
@seunghwak
reduce code repetition
55927e9
@seunghwak
remove debug printout
58799d9
@seunghwak
get large value by reference
a421a76
@seunghwak
copyright year
a413978
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
304b5c0 
…to fea_per_v_transform_reduce_edge_mask
@seunghwak
code refactor for re-use for other primitives
b2308d6
@seunghwak
code cleanup
d6653db
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
022be70 
…to enh_edge_mask_perf
@seunghwak
fewer edge_partition_e_mask.has_value() if edge masking is disabled
e9c3b7e
@seunghwak
Merge branch 'branch-24.02' of https://github.com/rapidsai/cugraph in…
71fa51d 
…to enh_edge_mask_perf
@seunghwak
minimize performance regression in transform_reduce_e with the edge m…
fe2bf35 
…asking support update (when edge masking is disabled)
@seunghwak seunghwak added this to the 24.04 milestone Jan 26, 2024
@seunghwak seunghwak self-assigned this Jan 30, 2024
@seunghwak seunghwak added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed CMake python ci conda labels Jan 30, 2024
@seunghwak seunghwak changed the base branch from branch-24.02 to branch-24.04 January 30, 2024 18:57
@seunghwak seunghwak marked this pull request as ready for review January 30, 2024 19:32
@seunghwak seunghwak requested a review from a team as a code owner January 30, 2024 19:32
@seunghwak seunghwak mentioned this pull request Feb 8, 2024
Merged
@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 38a8cdb into rapidsai:branch-24.04 Feb 9, 2024
109 of 110 checks passed
@seunghwak seunghwak deleted the enh_edge_mask_perf branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naimnv naimnv naimnv approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

Assignees

@seunghwak seunghwak

Labels
cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
3 participants
@seunghwak @ChuckHastings @naimnv