Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx-cugraph: PLC now handles isolated nodes; clean up our workarounds #4092

Merged

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Jan 14, 2024

Hooray for removing and cleaning code! Tests also added (we already tested isolated nodes for Louvain).

nx-cugraph was updated to handle isolated nodes by passing the node set to PLC in #4077

@eriknw eriknw requested a review from a team as a code owner January 14, 2024 14:45
@eriknw eriknw added the non-breaking Non-breaking change label Jan 14, 2024
@eriknw
Copy link
Contributor Author

eriknw commented Jan 15, 2024

I forgot that #4071 was still open. @rlratzel let's merge this PR first then I can update #4071.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And thanks for adding the test too.

@rlratzel rlratzel added the improvement Improvement / enhancement to an existing function label Jan 16, 2024
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 4748ca1 into rapidsai:branch-24.02 Jan 16, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants