Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cugraph-pyg package name used in wheels and fix test script #4083

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Jan 10, 2024

This is an oversight from #4075. With this fix, the generated wheels should have proper a CUDA suffix (e.g. cugraph-pyg-cu12).

Edit: This PR also fixes https://github.com/rapidsai/graph_dl/issues/421
The mg tests were not skipped as expected due to wrong relative path in test_wheel_cugraph-pyg.sh.

@tingyu66 tingyu66 self-assigned this Jan 10, 2024
@tingyu66 tingyu66 added bug Something isn't working non-breaking Non-breaking change labels Jan 10, 2024
@github-actions github-actions bot added the ci label Jan 10, 2024
@tingyu66 tingyu66 changed the title Correct cugraph-pyg package name used in wheels Correct cugraph-pyg package name used in wheels and fix test script Jan 10, 2024
@tingyu66 tingyu66 marked this pull request as ready for review January 10, 2024 15:50
@tingyu66 tingyu66 requested review from a team as code owners January 10, 2024 15:50
@tingyu66 tingyu66 marked this pull request as draft January 10, 2024 15:50
@tingyu66 tingyu66 marked this pull request as ready for review January 10, 2024 16:09
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 35ae8ef into rapidsai:branch-24.02 Jan 10, 2024
97 checks passed
@tingyu66 tingyu66 deleted the fix-package-name branch January 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants