Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nx-cugraph notebook for showing accelerated networkX APIs #3830

Merged
merged 26 commits into from
Oct 17, 2023
Merged

Add nx-cugraph notebook for showing accelerated networkX APIs #3830

merged 26 commits into from
Oct 17, 2023

Conversation

betochimas
Copy link
Contributor

@betochimas betochimas commented Aug 28, 2023 •
edited by rlratzel
Loading

This PR adds a notebook showing how to use the nx-cugraph package to accelerate your NetworkX workflow.

closes rapidsai/graph_dl#277

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rlratzel
rlratzel reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dylan, looking good so far. I added a few items below.

cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.ipynb Outdated Show resolved Hide resolved
cugraph_nx_demo.py Outdated Show resolved Hide resolved
@betochimas betochimas changed the title Add cugraph-nx notebook for showing accelerated networkX APIs Add nx-cugraph notebook for showing accelerated networkX APIs Aug 30, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 30, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@betochimas
Copy link
Contributor Author

Remaining points to address and relevant info for whoever picks this up:
Currently this notebook

  • Shows which versions of Python, NetworkX, and cuGraph are compatible, where and how to install dev version of nX
  • A brief example of native NetworkX and accelerated NetworkX, with benchmarks
  • A section on customization tools to configure backend behavior
  • Lists which algs are supported

@BradReesWork BradReesWork added this to the 23.10 milestone Sep 25, 2023
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 26, 2023
@BradReesWork BradReesWork modified the milestones: 23.10, 23.12 Sep 26, 2023
@BradReesWork BradReesWork changed the base branch from branch-23.10 to branch-23.12 September 26, 2023 14:15
@rlratzel rlratzel marked this pull request as ready for review October 3, 2023 05:07
@rlratzel rlratzel requested a review from a team as a code owner October 3, 2023 05:07
@rlratzel
Copy link
Contributor

rlratzel commented Oct 3, 2023

/ok to test

@rlratzel

This comment was marked as duplicate.

Sign in to view
@rlratzel

This comment was marked as duplicate.

Sign in to view
@rlratzel

This comment was marked as duplicate.

Sign in to view
@rlratzel

This comment was marked as duplicate.

Sign in to view
@rlratzel rlratzel self-assigned this Oct 16, 2023
@rlratzel rlratzel requested a review from eriknw October 16, 2023 01:25
eriknw
eriknw reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good overall! I left a few suggestions for grammar and spelling mistakes.

Another thing to consider is usage of "networkx" and "NetworkX".

notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
notebooks/demo/nx_cugraph_demo.ipynb Outdated Show resolved Hide resolved
@rlratzel

This comment was marked as duplicate.

Sign in to view
@rlratzel

This comment was marked as duplicate.

Sign in to view
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit f0ea634 into rapidsai:branch-23.12 Oct 17, 2023
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@eriknw eriknw eriknw approved these changes

Assignees

@rlratzel rlratzel

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.12
Development

Successfully merging this pull request may close these issues.
4 participants
@betochimas @rlratzel @eriknw @BradReesWork