Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor python code for similarity algos to use latest CAPI #3828

Merged
merged 21 commits into from
Sep 21, 2023
Merged

Refactor python code for similarity algos to use latest CAPI #3828

merged 21 commits into from
Sep 21, 2023

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Aug 26, 2023 •
edited by ChuckHastings
Loading

This PR

  • refactors python code for similarity algorithms (Jaccard, Sorensen, Overlap) to use latest CAPI
  • removes legacy cuda c/c++ code and python wrapper around legacy code
  • update CAPI tests
  • remove and update python tests

Closes #2546
Closes #2547
Closes #2548
Closes #2549
Closes #2749

Refactor python code for similarity algos to use latest CAPI, get rid…
38d917a 
… of python wrapper around legacy code, update CAPI and python tests
@naimnv naimnv self-assigned this Aug 26, 2023
@naimnv naimnv changed the title Refactor python code for similarity algos to use latest CAPI, get rid… [skip-ci] Refactor python code for similarity algos to use latest CAPI, get rid… Aug 26, 2023
@naimnv naimnv marked this pull request as ready for review August 28, 2023 22:22
@naimnv naimnv requested review from a team as code owners August 28, 2023 22:22
@naimnv naimnv added bug Something isn't working non-breaking Non-breaking change feature request New feature or request labels Aug 28, 2023
@naimnv naimnv changed the title [skip-ci] Refactor python code for similarity algos to use latest CAPI, get rid… [skip-ci] Refactor python code for similarity algos to use latest CAPI Aug 28, 2023
@naimnv naimnv changed the title [skip-ci] Refactor python code for similarity algos to use latest CAPI Refactor python code for similarity algos to use latest CAPI Aug 28, 2023
@naimnv naimnv removed the feature request New feature or request label Aug 28, 2023
seunghwak
seunghwak approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed the C/C++ part only)

jnke2016
jnke2016 requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thanks again for the great work on this. I just had couple minor change requests

@ChuckHastings
Copy link
Collaborator

/ok to test

rlratzel
rlratzel requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, thanks. Just a few more suggestions related to comments, warnings, and docstrings.

python/cugraph/cugraph/link_prediction/jaccard.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/link_prediction/jaccard.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/link_prediction/jaccard.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/link_prediction/jaccard.py Show resolved Hide resolved
python/cugraph/cugraph/link_prediction/wjaccard.py Outdated Show resolved Hide resolved
@ChuckHastings
Copy link
Collaborator

/ok to test

rlratzel
rlratzel approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a53ab34 into rapidsai:branch-23.10 Sep 21, 2023
55 checks passed
@jnke2016 jnke2016 mentioned this pull request Sep 26, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request Sep 26, 2023
@jnke2016
Enable weights for MG similarity algorithms (#3879)
a9f4297 
This is a follow up PR to #3828 which enabled weighted for the python SG similarity algorithms. 
This PR also updates the tests, docstrings and remove experimental calls

Authors:
  - Joseph Nke (https://github.com/jnke2016)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)

URL: #3879
@jnke2016 jnke2016 mentioned this pull request Sep 26, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 requested changes

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@rlratzel rlratzel rlratzel approved these changes

@acostadon acostadon Awaiting requested review from acostadon

Assignees

@naimnv naimnv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
6 participants
@naimnv @BradReesWork @ChuckHastings @rlratzel @seunghwak @jnke2016