Remove Deprecated Sampling Options #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarghi-nv
added
improvement
BradReesWork
approved these changes
Aug 30, 2023
rlratzel
approved these changes
Aug 30, 2023
Yep, cuDF also considers this a breaking change so our labels are correct here. |
|
/merge |
rlratzel
pushed a commit
to rlratzel/cugraph
that referenced
this pull request
Sep 8, 2023
The `uniform_neighbor_sample` code is becoming increasingly difficult to maintain. This PR removes all the options that were deprecated in the previous release, and also deprecates the `with_edge_properties` option, which will be replaced by returning whatever properties are in the graph in the next release. This PR also resolves a FIXME by allowing `fanout_vals` to be a `cupy.ndarray`, `numpy.ndarray`, or `cudf.Series`. Closes rapidsai#3698 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) Approvers: - Brad Rees (https://github.com/BradReesWork) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#3816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uniform_neighbor_samplecode is becoming increasingly difficult to maintain. This PR removes all the options that were deprecated in the previous release, and also deprecates thewith_edge_propertiesoption, which will be replaced by returning whatever properties are in the graph in the next release.This PR also resolves a FIXME by allowing
fanout_valsto be acupy.ndarray,numpy.ndarray, orcudf.Series.Closes #3698