Add louvain_communities to cugraph-nx
#3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible follow-up tasks: - Update to use threshold parameter exposed from C++ (rapidsai#3792) - Add `max_level` argument to networkx implementation - Update PLC to handle empty graphs gracefully - Update PLC to handle directed graphs - Add `louvain_partitions` (needs added to PLC)
rlratzel
reviewed
Aug 17, 2023
rlratzel
approved these changes
Aug 17, 2023
rlratzel
added
improvement
|
But, now |
|
/ok to test |
|
/merge |
|
/ok to test |
rlratzel
pushed a commit
to rlratzel/cugraph
that referenced
this pull request
Sep 8, 2023
See: rapidsai#3773 Possible follow-up tasks: - Update to use threshold parameter exposed from C++ (rapidsai#3792) - Add `max_level` argument to networkx implementation - ~Or, add `max_level` as extra`cugraph_nx`-specific argument~ (**done**) - Update PLC to handle empty graphs gracefully (rapidsai#3804) - Update PLC to handle directed graphs - Add `louvain_partitions` (needs added to PLC) - https://networkx.org/documentation/stable/reference/algorithms/generated/networkx.algorithms.community.louvain.louvain_partitions.html This is passing many networkx tests. I don't have this as draft, b/c it's usable (and I would argue) mergable as is. Authors: - Erik Welch (https://github.com/eriknw) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#3803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #3773
Possible follow-up tasks:
max_levelargument to networkx implementationOr, add(done)max_levelas extracugraph_nx-specific argumentcugraph.louvaindoes not handle empty graphs well #3804)louvain_partitions(needs added to PLC)This is passing many networkx tests. I don't have this as draft, b/c it's usable (and I would argue) mergable as is.