Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python_run_cugraph in dependencies.yaml #3781

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Update python_run_cugraph in dependencies.yaml #3781

merged 10 commits into from
Aug 21, 2023

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Aug 11, 2023 •
edited
Loading

Closes #2811

This PR adds aiohttp and requests as hard dependencies to cugraph. Without these packages, cugraph.datasets is unable to download missing datasets. cugraph.datasets uses cudf.read_csv to download files from s3.

@nv-rliu nv-rliu added the ? - Needs Triage Need team to review and classify label Aug 11, 2023
@nv-rliu nv-rliu marked this pull request as ready for review August 17, 2023 14:16
@nv-rliu nv-rliu requested a review from a team as a code owner August 17, 2023 14:16
@bdice
Copy link
Contributor

bdice commented Aug 17, 2023

See comments here -- I don't think these changes are needed.
#2811 (comment)
#2811 (comment)

@nv-rliu nv-rliu requested a review from a team as a code owner August 17, 2023 18:17
bdice
bdice requested changes Aug 17, 2023
View reviewed changes
conda/recipes/cugraph/meta.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
bdice
bdice reviewed Aug 17, 2023
View reviewed changes
conda/recipes/cugraph/meta.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@bdice bdice mentioned this pull request Aug 17, 2023
Closed
bdice
bdice reviewed Aug 17, 2023
View reviewed changes
conda/recipes/cugraph/meta.yaml Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change and removed ? - Needs Triage Need team to review and classify labels Aug 17, 2023
bdice
bdice approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nv-rliu! This looks right to me, now.

rlratzel
rlratzel requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small change to potentially eliminate confusion.

dependencies.yaml Outdated Show resolved Hide resolved
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 8b1f014 into rapidsai:branch-23.10 Aug 21, 2023
54 checks passed
@nv-rliu nv-rliu deleted the conda-recipes branch August 21, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees

@nv-rliu nv-rliu

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] conda recipies missing packages for Dataset API
5 participants
@nv-rliu @bdice @rlratzel @raydouglass @BradReesWork