Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward-merge branch-23.08 to branch-23.10 #3774

Merged
merged 11 commits into from
Aug 10, 2023
Merged

Forward-merge branch-23.08 to branch-23.10 #3774

merged 11 commits into from
Aug 10, 2023

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Aug 8, 2023

Replaces #3755

nv-rliu and others added 10 commits July 28, 2023 04:43
@nv-rliu
Promote Datasets to stable and clean-up unit tests (rapidsai#3712)
836c27a 
Addresses rapidsai#3675 and rapidsai#3706 

This PR moves the `datasets` API from experimental to stable. Users can now do:

```python
from cugraph.datasets import karate

G = karate.get_graph()
```

The existing `experimental.datasets` package has been updated with the `promoted_experimental_warning_wrapper()`. All notebooks, docstrings, and unit test dependencies on `datasets` have been updated to use the stable API.

This PR also removes the networkx warning suppression from the unit tests.

Authors:
  - ralph (https://github.com/nv-rliu)
  - Naim (https://github.com/naimnv)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#3712
@ajschmidt8
Fix build.yaml workflow (rapidsai#3756)
9a60e51 
This PR fixes the `build.yaml` workflow. The `node_type` reusable workflow input was placed incorrectly in rapidsai#3712.

Skipping CI since this file isn't tested in PRs.

[skip ci]
@rlratzel
Fixes options for --pydevelop to remove unneeded CWD path ("."), re…
f2b4912 
…stores use of `setup.py` temporarily for develop builds (rapidsai#3747)

This PR adds the following:
* Removes the now unnecessary "." path used in the install options when `--pydevelop` is used, which resulted in an error when called.
* Temporarily adds a call to `setup.py bdist_ext --inplace` only when `--pydevelop` is used to workaround a [bug in scikit-build](scikit-build/scikit-build#981) when `setuptools>=64` is installed.

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#3747
@VibhuJawa
Support MFG creation on sampling gpus for cugraph dgl (rapidsai#3742)
be2a63e 
This PR builds on top of rapidsai#3734

Merge after rapidsai#3734

Todo tests for:  
- [x] _get_renumber_map
- [x]  _get_tensor_d_from_sampled_df
- [x] create_homogeneous_sampled_graphs_from_dataframe
- [x] pytests pass
- [x] dataset_from_disk_cudf.ipynb (`obgn_products_sampling/`)
- [x] Verify training benchmark

Authors:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)

URL: rapidsai#3742
@naimnv
Update primitive to compute weighted Jaccard, Sorensen and Overlap si…
14862c6 
…milarity (rapidsai#3728)

This PR
- changes `per_v_pair_transform_dst_nbr_intersection` to support computing weighted intersection
- updates implementation of `similarity`, `jaccard_coefficients`, `sorensen_coefficients`, `overlap_coefficients` for weighted  graphs

NOTE: current implementation doesn't support computing similarity for multi-edge graphs.

closes rapidsai#2748
closes rapidsai#3477

Authors:
  - Naim (https://github.com/naimnv)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Joseph Nke (https://github.com/jnke2016)

URL: rapidsai#3728
@ChuckHastings
Fix bug discovered in Jaccard testing (rapidsai#3758)
b6de267 
A customer identified an issue trying to run Jaccard.  In MG calls they were seeing failed memory allocation calls.

Vertices were being shuffled incorrectly in the C API, so we were getting vertices processed on the wrong GPU, resulting in out-of-bounds memory references.

Moved the shuffle before renumbering, which puts vertices to be on proper GPU

Closes rapidsai#3746

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#3758
@galipremsagar
Pin dask and distributed for 23.08 release (rapidsai#3761)
f4627f8 
This PR pins `dask` & `distributed` to `2023.7.1` version for `23.08` release.

xref: rapidsai/cudf#13802

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Ray Douglass (https://github.com/raydouglass)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: rapidsai#3761
@seunghwak
Change the renumber_sampled_edgelist function behavior. (rapidsai#3762)
f6543f6 
There was a misalignment between the `renumber_sampled_edgelist` function behavior and what PyG and DGL need.

This PR fixes this.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: rapidsai#3762
@jnke2016
fix inconsistent graph properties between the SG and the MG API (rapi…
62ecea2 
…dsai#3757)

Several graph methods are failing, some being an effect of migrating away from cython.cu renumbering.
This PR fixes couple graph methods and fixes the inconsistency in results returned by the SG and MG API


closes rapidsai#3740 
closes rapidsai#3766

Authors:
  - Joseph Nke (https://github.com/jnke2016)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#3757
Merge branch-23.08 into branch-23.10
a8444b0
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@nv-rliu nv-rliu marked this pull request as ready for review August 8, 2023 22:02
@nv-rliu nv-rliu requested review from a team as code owners August 8, 2023 22:02
@nv-rliu nv-rliu added ? - Needs Triage Need team to review and classify graph-devops Issues for the graph-devops team labels Aug 8, 2023
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed ? - Needs Triage Need team to review and classify graph-devops Issues for the graph-devops team labels Aug 9, 2023
@nv-rliu nv-rliu mentioned this pull request Aug 9, 2023
Closed
@raydouglass raydouglass merged commit c55151c into rapidsai:branch-23.10 Aug 10, 2023
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@nv-rliu @rlratzel @raydouglass @ajschmidt8 @VibhuJawa @naimnv @ChuckHastings @galipremsagar @seunghwak @jnke2016